Closed
Conversation
these being outdated is breaking compatibility with embassy. no changes to existing code required to build after updates.
Contributor
|
Thanks for the contribution! Please fix the failing tests. |
The examples just needed their packages updated too, along with a few minor semantics changes. The custom error types also now need to implement core::error::Error, so I implemented that for them as well. Also updated changelog.
Contributor
Author
|
@eivindbergem I have fixed the examples and updated the changelog. Everything is building now. I also deleted the Cargo.lock files in each subdirectory as they are out of date now. |
Contributor
Author
|
Closing this for now as I finally got around to testing the examples on hardware and it's not working properly. I'll resubmit if I can figure out the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded-io and embedded-io-async being outdated is breaking compatibility with embassy. No changes to existing code required to build after updates.